Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add clang job and setup concurrency #1407

Merged
merged 17 commits into from
Dec 9, 2024
Merged

[CI] Add clang job and setup concurrency #1407

merged 17 commits into from
Dec 9, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Dec 3, 2024 •
edited
Loading

  • This adds a semi-binary job using clang. I fixed all what clang was complaining about.
  • use humble branch of realtime_tools for humble CI

Additionally, I added the concurrency settings which now automatically cancel running workflows if anything is pushed to PRs.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs

@christophfroehlich christophfroehlich marked this pull request as draft December 4, 2024 11:14
@christophfroehlich christophfroehlich changed the title [CI] Add clang job [CI] Add clang job and setup concurrency Dec 4, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.91667% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.59%. Comparing base (de42962) to head (7fad712).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ntroller/test/test_trajectory_controller_utils.hpp 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
- Coverage   83.60%   83.59%   -0.01%     
==========================================
  Files         122      122              
  Lines       11007    11018      +11     
  Branches      934      935       +1     
==========================================
+ Hits         9202     9211       +9     
- Misses       1494     1495       +1     
- Partials      311      312       +1
Flag Coverage Δ
unittests 83.59% <97.91%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/admittance_controller/admittance_rule.hpp 100.00% <100.00%> (ø)
...ude/admittance_controller/admittance_rule_impl.hpp 92.82% <100.00%> (+0.16%) ⬆️
...dmittance_controller/src/admittance_controller.cpp 74.15% <100.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 76.51% <100.00%> (ø)
...ller/test/test_load_forward_command_controller.cpp 100.00% <100.00%> (ø)
..._broadcaster/test/test_joint_state_broadcaster.cpp 96.62% <100.00%> (ø)
...include/joint_trajectory_controller/tolerances.hpp 79.79% <100.00%> (ø)
...include/joint_trajectory_controller/trajectory.hpp 75.00% <100.00%> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 83.90% <100.00%> (ø)
joint_trajectory_controller/src/trajectory.cpp 91.35% <100.00%> (ø)
... and 5 more

... and 5 files with indirect coverage changes

@christophfroehlich christophfroehlich marked this pull request as ready for review December 5, 2024 21:39
@github-actions github-actions bot requested review from erickisos and fmauch December 5, 2024 21:51
@github-actions github-actions bot requested a review from mcbed December 5, 2024 21:51
saikishor
saikishor approved these changes Dec 8, 2024
View reviewed changes
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Some castings are new to me hahaa
If the CI is happy, I'm fine with it

@christophfroehlich
Copy link
Contributor Author

LGTM in general. Some castings are new to me hahaa If the CI is happy, I'm fine with it

I used now explicit iterator's difference_type cast instead of the ptrdiff(which is normally the same..)

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Dec 9, 2024
@christophfroehlich christophfroehlich merged commit 66d160c into master Dec 9, 2024
19 of 21 checks passed
@christophfroehlich christophfroehlich deleted the ci/clang branch December 9, 2024 16:15
mergify bot pushed a commit that referenced this pull request Dec 9, 2024
@christophfroehlich @mergify
[CI] Add clang job and setup concurrency (#1407)
b8b1303 
(cherry picked from commit 66d160c)

# Conflicts:
#	forward_command_controller/test/test_load_forward_command_controller.cpp
#	joint_trajectory_controller/src/trajectory.cpp
#	tricycle_controller/src/tricycle_controller.cpp
@mergify mergify bot mentioned this pull request Dec 9, 2024
Merged
christophfroehlich added a commit that referenced this pull request Dec 10, 2024
@christophfroehlich
[CI] Add clang job and setup concurrency (#1407)
1198569
christophfroehlich pushed a commit that referenced this pull request Dec 10, 2024
@mergify
[CI] Add clang job and setup concurrency (backport #1407) (#1418)
b9816b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@arne48 arne48 Awaiting requested review from arne48

@bmagyar bmagyar Awaiting requested review from bmagyar

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@destogl destogl Awaiting requested review from destogl

@moriarty moriarty Awaiting requested review from moriarty

@Raivias Raivias Awaiting requested review from Raivias

@erickisos erickisos Awaiting requested review from erickisos

@fmauch fmauch Awaiting requested review from fmauch

@mcbed mcbed Awaiting requested review from mcbed

Assignees
No one assigned
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @saikishor